Improving the tables

Discuss and participate of this important initiative project.

Re: Improving the tables

Postby kwillems » Tue Dec 30, 2008 9:30 pm

I've just submitted the patch, see http://dev.fckeditor.net/ticket/1865
kwillems
 
Posts: 75
Joined: Fri Feb 03, 2006 2:14 pm

Re: Improving the tables

Postby kwillems » Wed Dec 31, 2008 2:39 am

There are still some questions left that need to be answered before the handling of tables can be further improved.

1. Should it be possible to merge down cells from thead to tbody?
2. If so, should the merged cell be in thead or in tbody?
3. Take a default 3 * 2 table, split one cell horizontaly and merge it back to one cell. All cells in that column have a colspan="2". Should that stay that way or should the colspan be lowered (and in this case: removed)?
4. Should the merging of a th-cel with a td-cell result in a th-cell (it does at the moment) or a td-cell?
kwillems
 
Posts: 75
Joined: Fri Feb 03, 2006 2:14 pm

Re: Improving the tables

Postby fredck » Wed Dec 31, 2008 10:07 am

kwillems wrote:1. Should it be possible to merge down cells from thead to tbody?
2. If so, should the merged cell be in thead or in tbody?
4. Should the merging of a th-cel with a td-cell result in a th-cell (it does at the moment) or a td-cell?

I believe those represent different groups of cell and the merging operations should be limited to a single group.

kwillems wrote:3. Take a default 3 * 2 table, split one cell horizontaly and merge it back to one cell. All cells in that column have a colspan="2". Should that stay that way or should the colspan be lowered (and in this case: removed)?

Having clean HTML is good. There is no sense having a column with all cells at the same colspan, and the same for rows with rowspan. So, I think it would be nice if the splitting operations would lowerdown *span attributes, finally removing them at zero.
Frederico Caldeira Knabben
CEO, CKSource
fredck
Site Admin
 
Posts: 856
Joined: Fri Jan 19, 2007 8:10 am

Re: Improving the tables

Postby alfonsoml » Wed Dec 31, 2008 3:49 pm

1. Should it be possible to merge down cells from thead to tbody?
2. If so, should the merged cell be in thead or in tbody?

If they are really part of the header then it makes no sense to merge them with the data cells. They are part of different elements so they shouldn't be merged.

4. Should the merging of a th-cel with a td-cell result in a th-cell (it does at the moment) or a td-cell?

The current behavior is based on the top-left cell, there's no need to add extra rules (and code that must be written and tested). If the user doesn't like the output he can change the type of the merged cell.
alfonsoml
 
Posts: 2665
Joined: Sun Dec 31, 2006 9:50 am
Location: Spain

Re: Improving the tables

Postby kwillems » Wed Dec 31, 2008 4:11 pm

If they are really part of the header then it makes no sense to merge them with the data cells. They are part of different elements so they shouldn't be merged.


I was a bit in doubt on this one. It should be possible to extend the thead.
On the other hand: it's still possible to insert an extra row in thead and copy/paste data from tbody into it if needed.
kwillems
 
Posts: 75
Joined: Fri Feb 03, 2006 2:14 pm

Re: Improving the tables

Postby kwillems » Thu Jan 15, 2009 9:52 pm

I just added a new ticket about the merging of cells from one table section to another, see http://dev.fckeditor.net/ticket/2777.
A little patch is already submitted.

I'm not sure if it should be made possible to merge cells between tbodies (there could be more than one). At the moment the patch does not allow that kind of merging.
kwillems
 
Posts: 75
Joined: Fri Feb 03, 2006 2:14 pm

Re: Improving the tables

Postby kwillems » Thu Jan 15, 2009 10:33 pm

Furthermore I added a ticket and a patch for the colspan issue here http://dev.fckeditor.net/ticket/2778
kwillems
 
Posts: 75
Joined: Fri Feb 03, 2006 2:14 pm

Re: Improving the tables

Postby kwillems » Fri Jan 16, 2009 3:35 am

And I've submitted a patch for this ticket: http://dev.fckeditor.net/ticket/2656.
kwillems
 
Posts: 75
Joined: Fri Feb 03, 2006 2:14 pm

Re: Improving the tables

Postby fredck » Fri Jan 16, 2009 9:07 am

@kwillems, thanks for the new patches.

We are under beta stabilization now, so I'm afraid those tickets will be retarget to a future release. Only critical tickets should be targeted to the 2.6.4 at this point.
Frederico Caldeira Knabben
CEO, CKSource
fredck
Site Admin
 
Posts: 856
Joined: Fri Jan 19, 2007 8:10 am

Re: Improving the tables

Postby kwillems » Fri Jan 16, 2009 11:06 am

:-)

Well, but can they can be reviewed? (so i can carry on with other issues in tablehandler.js)
And to which version should i target these tickets and patches?
kwillems
 
Posts: 75
Joined: Fri Feb 03, 2006 2:14 pm

PreviousNext

Return to CKEditor 3.x

Who is online

Users browsing this forum: Ask Jeeves [Bot], Google [Bot] and 2 guests